Skip to content

GLORYSMonthly's last_date is wrong #620

@xkykai

Description

@xkykai

GLORYSMonthly only contains data up to June 1 2021 (inclusive) but this is not the case in the code

all_dates(::GLORYSMonthly, var) = range(DateTime("1993-01-01"), stop=DateTime("2024-12-01"), step=Month(1))

Here's an MWE trying to download data of July 1 2021:

using ClimaOcean
using ClimaOcean.Copernicus
using ClimaOcean.DataWrangling
using Printf
using Dates
using PythonCall
using ClimaOcean.DataWrangling: download_dataset

dataset = GLORYSMonthly()
date = DateTime(2021, 8, 1)
T = Metadatum(:temperature; dataset, date)
download_dataset(T)
ERROR: Python: CoordinatesOutOfDatasetBounds: Some of your subset selection [2021-08-01 00:00:00+00:00, 2021-08-01 00:00:00+00:00] for the time dimension exceed the dataset coordinates [1993-01-01 00:00:00+00:00, 2021-06-01 00:00:00+00:00]
Python stacktrace:
 [1] _check_coordinate_overlap
   @ copernicusmarine.download_functions.subset_xarray C:\Users\xinle\.julia\environments\v1.11\.CondaPkg\.pixi\envs\default\Lib\site-packages\copernicusmarine\download_functions\subset_xarray.py:819
 [2] check_dataset_subset_bounds
   @ copernicusmarine.download_functions.subset_xarray C:\Users\xinle\.julia\environments\v1.11\.CondaPkg\.pixi\envs\default\Lib\site-packages\copernicusmarine\download_functions\subset_xarray.py:744
 [3] subset_function
   @ copernicusmarine.core_functions.subset C:\Users\xinle\.julia\environments\v1.11\.CondaPkg\.pixi\envs\default\Lib\site-packages\copernicusmarine\core_functions\subset.py:156
 [4] subset
   @ copernicusmarine.python_interface.subset C:\Users\xinle\.julia\environments\v1.11\.CondaPkg\.pixi\envs\default\Lib\site-packages\copernicusmarine\python_interface\subset.py:195
 [5] wrapper
   @ copernicusmarine.python_interface.exception_handler C:\Users\xinle\.julia\environments\v1.11\.CondaPkg\.pixi\envs\default\Lib\site-packages\copernicusmarine\python_interface\exception_handler.py:13
 [6] wrapper
   @ copernicusmarine.python_interface.exception_handler C:\Users\xinle\.julia\environments\v1.11\.CondaPkg\.pixi\envs\default\Lib\site-packages\copernicusmarine\python_interface\exception_handler.py:17
 [7] wrapper
   @ copernicusmarine.core_functions.deprecated_options C:\Users\xinle\.julia\environments\v1.11\.CondaPkg\.pixi\envs\default\Lib\site-packages\copernicusmarine\core_functions\deprecated_options.py:78
Stacktrace:
  [1] pythrow()
    @ PythonCall.Core C:\Users\xinle\.julia\packages\PythonCall\IOKTD\src\Core\err.jl:77
  [2] errcheck
    @ C:\Users\xinle\.julia\packages\PythonCall\IOKTD\src\Core\err.jl:10 [inlined]
  [3] pycallargs(f::Py, args::Py, kwargs::Py)
    @ PythonCall.Core C:\Users\xinle\.julia\packages\PythonCall\IOKTD\src\Core\builtins.jl:204
  [4] #pycall#21
    @ C:\Users\xinle\.julia\packages\PythonCall\IOKTD\src\Core\builtins.jl:219 [inlined]
  [5] pycall
    @ C:\Users\xinle\.julia\packages\PythonCall\IOKTD\src\Core\builtins.jl:215 [inlined]
  [6] Py
    @ C:\Users\xinle\.julia\packages\PythonCall\IOKTD\src\Core\Py.jl:343 [inlined]
  [7] macro expansion
    @ C:\Users\xinle\.julia\packages\Oceananigans\Xjsq1\src\DistributedComputations\distributed_macros.jl:31 [inlined]
  [8] download_dataset(meta::Metadatum{GLORYSMonthly, DateTime, Nothing}; skip_existing::Bool, additional_kw::@Kwargs{})
    @ ClimaOceanPythonCallExt c:\Users\xinle\Dropbox\MIT\1deg_simulation\ClimaOcean.jl\ext\ClimaOceanPythonCallExt.jl:77
  [9] download_dataset(meta::Metadatum{GLORYSMonthly, DateTime, Nothing})
    @ ClimaOceanPythonCallExt c:\Users\xinle\Dropbox\MIT\1deg_simulation\ClimaOcean.jl\ext\ClimaOceanPythonCallExt.jl:38
 [10] top-level scope
    @ REPL[14]:1

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions