Skip to content

Conversation

kmdeck
Copy link
Member

@kmdeck kmdeck commented Mar 14, 2025

Purpose

Add helper functions which compute the total water volume and energy per unit area on land.
partially closes Issue #1038

To-do

Content

Creates the total_energy_per_area! and total_liq_water_vol_per_area! functions for AbstractModels
Creates the specific method of these for: Richards, EnergyHydrology, Snow, Canopy
Tests these methods for standalone models
Creates a method for LandModels
Tests this method for the snowy land model


  • I have read and checked the items on the review checklist.

@kmdeck kmdeck changed the title Adds functions for models to compute total energy and mass per area Adds functions for models to compute total energy and water volume(mass) per area Mar 14, 2025
@kmdeck kmdeck self-assigned this Mar 14, 2025
@kmdeck kmdeck force-pushed the kd/total_water_energy_functions branch from 1e6b0e9 to bd3291c Compare March 18, 2025 16:28
@kmdeck kmdeck requested a review from juliasloan25 March 18, 2025 17:17
Copy link
Member

@juliasloan25 juliasloan25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you Kat! It would be helpful to clarify that, although total_liq_water_vol_per_area! returns the volume of liquid water, it includes contributions from all phases.

Could you also update the NEWS please?

@kmdeck
Copy link
Member Author

kmdeck commented Mar 19, 2025

This looks great, thank you Kat! It would be helpful to clarify that, although total_liq_water_vol_per_area! returns the volume of liquid water, it includes contributions from all phases.

Could you also update the NEWS please?

yes! will do for both

@kmdeck kmdeck force-pushed the kd/total_water_energy_functions branch from 5801c0f to 2f009b3 Compare March 19, 2025 22:46
@kmdeck kmdeck enabled auto-merge (squash) March 19, 2025 22:50
@kmdeck kmdeck merged commit 521d7cd into main Mar 20, 2025
14 of 16 checks passed
@kmdeck kmdeck deleted the kd/total_water_energy_functions branch March 20, 2025 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove allocations in energy hydrology total water content computation

2 participants