Refactor FD shmem index management #2299
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/fd_shmem_refactor
branch
2 times, most recently
from
d0214a6 to
016ca4d
Compare
Merged
charleskawczynski
force-pushed
the
ck/fd_shmem_refactor
branch
4 times, most recently
from
22ac58d to
c105d3e
Compare
charleskawczynski
force-pushed
the
ck/fd_shmem_refactor
branch
from
c105d3e to
d299c24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the FD shmem so that, for example, changing the number of dimensions for shmem can be done in a more isolated section.