fix: error on inconsistent diffusion option #4051
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haakon-e
force-pushed
the
he/fix-error-on-inconsistent
branch
from
b515307 to
b5b3159
Compare
haakon-e
force-pushed
the
he/fix-error-on-inconsistent
branch
from
b5b3159 to
1aabddf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces improved error handling and model differentiation in the
update_jacobian!function within themanual_sparse_jacobian.jlfile. The changes ensure that unsupported or unknown vertical diffusion types are caught early and provide clearer handling for different turbulence convection models.Key changes:
Model differentiation and error handling:
AbstractEDMFturbulence convection models in the conditional logic, making the code more robust and maintainable.vertical_diffusiontypes, preventing silent failures and aiding debugging.Anna and I ran into this
elseblock while working with Smagorinsky diffusion for her simulation setup (i.e. yaml hasvert_diff: false, and no EDMF).It is likely due to incorrectly configured yaml file: i.e.
implicit_diffusion: trueis only compatible withDecayWithHeightDiffusion,VerticalDiffusion, or (I presume) EDMF-type closures. For convenience, this PR proposes to explicitly check this both during model construction, and make it clearer within the jacobian that the last block pertains to EDMF.