rft: clean up hyperdiffusion #4049
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors and streamlines the hyperdiffusion logic in
src/prognostic_equations/hyperdiffusion.jl
, focusing on code clarity, maintainability, and consistency.Key improvements and changes:
moisture_model
fromatmos
, orᶜu
fromp.precomputed
) to simplify and shorten their inline usageFor example, instead of the (somewhat confusing) expression
I propose assigning a new name to the resulting calculation. Importantly, this does not affect the underlying memory of the data
These changes collectively improve the maintainability and readability of the hyperdiffusion implementation, while ensuring consistent and correct use of model parameters throughout the codebase.