Implementing double-sided limiters #4037
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing in CI here and also with high resolution MBW |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triangle limiter flips the sign of the tendency if we are limiting by negative numbers. The tendency in that case becomes unbounded. It is possible in our simulations to have spurious negative tracers.
This PR changes the triangle limiter behavior. If limiting by negative number the source and destination categories are swapped. We try to limit this new force by the amount available in the old destination category. If both source and destination are negative, we return zero, as there is nothing the limiter can do.
If no second limiter is provided for negative tracer case, the tendency is set to zero. This is used for example when limiting the number concentration tendencies.