Check convergence of Schar mountain test #4031
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisYatunin
force-pushed
the
dy/schar_mountain_convergence
branch
3 times, most recently
from
5587eda to
ec1040f
Compare
…intain consistency with GS variables
water species. Interpolate IC to arbitrary vertical grid. Generalize paths for IC.
Co-authored-by: akshaysridhar <asridhar@caltech.edu> Co-authored-by: dennisYatunin <dyatun@gmail.com> Co-authored-by: ray-chew <chew@caltech.edu>
dennisYatunin
force-pushed
the
dy/schar_mountain_convergence
branch
2 times, most recently
from
f2f9380 to
ba4b410
Compare
|
Branch has just been rebased off as/paper-revisions. The values generated on this run will be reported in the dycore paper. |
dennisYatunin
force-pushed
the
dy/schar_mountain_convergence
branch
7 times, most recently
from
e9e7306 to
24b8929
Compare
dennisYatunin
force-pushed
the
dy/schar_mountain_convergence
branch
from
a295c7b to
573408f
Compare
dennisYatunin
force-pushed
the
dy/schar_mountain_convergence
branch
2 times, most recently
from
e066045 to
414ae20
Compare
…_r from other term
dennisYatunin
force-pushed
the
dy/schar_mountain_convergence
branch
from
414ae20 to
0252ad5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR generalizes the ScharTopography to allow an arbitrary mountain height, and it modifies our buildkite pipeline to run the Schar mountain test with different values of h_max between 1 meter and 200 meters. Tapio and I want to confirm that the steady state converges in a reasonable way as the mountain height goes to 0, since one of the dycore paper reviewers thought that our steady state's error was too big.