-
Notifications
You must be signed in to change notification settings - Fork 26
Rename variable after AtmosModel refactor #3886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9394a8a
to
23a092a
Compare
Could you also rename |
Do you prefer |
I prefer |
d16fcff
to
106356f
Compare
106356f
to
39c0ba5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you!
39c0ba5
to
6b9be26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Will take some time to get used to grepping for microphysics_model
rather than precip_model
;) But I think the changes do improve the code readability.
Rename precip_model -> microphysics_model, don't change config arg Rename PrognosticSurfaceTemperature -> SlabOceanSST, PrescribedSurfaceTemp to PrescribedSST
64c002b
to
a909d7d
Compare
Purpose
Finish renaming variables after #3875. This is a breaking PR due to name changes within AtmosModel.
To-do
Content
Rename:
Note that all parsed args are still supported but `"prognostic_surface" = "prognostic/prescribedsurfacetemperature" is deprecated.