Add unit tests for some reproducibility infrastructure #3437
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some unit tests for the reproducibility infrastructure, and attempts to improve the documentation.
Thanks for suggesting this, @Sbozzolo.
One downside of this PR is that I've removed this check:
But I think it no longer makes sense in the context of
latest_comparable_paths
returning comparable paths, because the path must contain the same ref counter as the main branch (which is now specified as a function argument).Am I missing any edge cases that could happen?