Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add lookup table for aerosols #3156

Merged
merged 1 commit into from
Jul 2, 2024
Merged

add lookup table for aerosols #3156

merged 1 commit into from
Jul 2, 2024

Conversation

szy21
Copy link
Member

@szy21 szy21 commented Jun 28, 2024

Purpose

Closes #3154

To-do

Content

  • I have read and checked the items on the review checklist.

@szy21 szy21 force-pushed the zs/lookup_aerosol branch 3 times, most recently from bdbe361 to 79b7f0d Compare June 28, 2024 21:58
@szy21 szy21 marked this pull request as ready for review June 28, 2024 22:26
@szy21 szy21 added radiation ☀️ enhancement New feature or request labels Jul 1, 2024
nefrathenrici
nefrathenrici approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@nefrathenrici nefrathenrici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Will we always want to use the Merra lookup table?

@szy21
Copy link
Member Author

szy21 commented Jul 2, 2024

Thank you! Will we always want to use the Merra lookup table?

I think that's the only one we have now.

@szy21 szy21 added this pull request to the merge queue Jul 2, 2024
Merged via the queue into main with commit bd2750b Jul 2, 2024
12 of 13 checks passed
@szy21 szy21 deleted the zs/lookup_aerosol branch July 2, 2024 20:05
@szy21 szy21 mentioned this pull request Jul 3, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nefrathenrici nefrathenrici nefrathenrici approved these changes

@dennisYatunin dennisYatunin Awaiting requested review from dennisYatunin

@sriharshakandala sriharshakandala Awaiting requested review from sriharshakandala

Assignees
No one assigned
Labels
enhancement New feature or request radiation ☀️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add aerosol lookup table to RRTMGP interface
2 participants
@szy21 @nefrathenrici