Bugfix: Exempt missions in status yet_to_start from is_complete

[Anubioz]

Summary

Bugfixes "missions in yet_to_start status should be exempted from is_complete checks"

Purpose of change

While analyzing performance issues for my crafting/sleeping, it showed that almost 70% of CPU was used by the mission:is_complete checks

But heck my character didn't even had any missions. Long stort short, game automatically adds hidden mission MISSION_LEARN_ABOUT_CATTAIL_JELLY with MGOAL_CONDITION type and u_has_item check. So effectively that does a full inventory iteration every turn.

Describe the solution

So why would even check for completeness a mission that hasn't even started? We have another check for yet_to_start type (which would change the mission state to the in_progress status). As soon as those are not checked there is a huge performance boost for every long task

Describe alternatives you've considered

Just removing MISSION_LEARN_ABOUT_CATTAIL_JELLY or modifying it to NOT check for any inventory items should work just as well

Testing

It compiles, it runs...

Additional context

No AI this time, no strange overhaul ideas, will it work this way or am I mistaken again?

[github-actions]

You are creating a pull request with the master branch as the head branch. This is completely fine if you plan to make contribution once or do not plan to do it often, but if you are interested in making multiple pull requests within a short span of time, this would prevent you from doing it comfortably. You may read https://docs.github.com/en/get-started/quickstart/contributing-to-projects#creating-a-branch-to-work-on for a typical workflow of contributing to a project on GitHub.

[Anubioz]

Oh and now I see that function should have return false; I knew I would screw up even in 3 lines of c++ code, sorry guys )
Should i recommit or can you please make the change yourself, please please

[PatrikLundell]

When you screw up in a PR (which is bound to happen sooner or later for everyone), you update the PR yourself and submit that to the same PR as another commit, so you don't need to ask others to do it for you.