Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send debug messages to Windows debugger #78838

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Send debug messages to Windows debugger #78838

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
1dfce02
Convert PATH_INFO::debug to a cata_path
alef Dec 29, 2024
1a27204
Add classes to write both ostream and Windows debugger
alef Dec 29, 2024
dd528f9
Obey astyle
alef Dec 29, 2024
6d05cfb
Move the singleton into its struct
alef Dec 31, 2024
5cdaf81
Move deinit() into the destructor
alef Dec 31, 2024
123243d
Remove default constructor
alef Dec 31, 2024
7346fe7
Initialize `file` in the declaration
alef Dec 31, 2024
6f48488
Call instance() to get the singleton
alef Dec 31, 2024
4ba1ac0
Rename because it could be stderr
alef Dec 31, 2024
56f7d30
Move file logic outside the DebugOutput::file case
alef Dec 31, 2024
7eb0a7c
Move OutputDebugStreamA instantiation into init()
alef Dec 31, 2024
1ba1235
Initialize member in declaration. Increase max buffer
alef Dec 31, 2024
d772dd6
Rename to send() and change the logic
alef Dec 31, 2024
725cca8
Avoid sending newlines & co. to DebugView
alef Dec 31, 2024
c2fdae6
Sync `debug.log` every time we call OutputDebugStringA
alef Dec 31, 2024
5c93a28
Obey astyle
alef Dec 31, 2024
23db3d2
Remove unused variable
alef Jan 2, 2025
323f7fa
Remove access specifiers and reformat
alef Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move deinit() into the destructor
  • Loading branch information
@alef
alef committed Dec 31, 2024
commit 5cdaf81aaae15b57a634bd46cf6fd270afcb13bb
8 changes: 1 addition & 7 deletions src/debug.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,7 +689,6 @@ struct DebugFile {
DebugFile();
~DebugFile();
void init( DebugOutput, const cata_path &filename );
void deinit();
std::ostream &get_file();
static DebugFile& instance() {
static DebugFile instance;
Expand All @@ -709,11 +708,6 @@ struct DebugFile {
DebugFile::DebugFile() = default;

DebugFile::~DebugFile()
{
deinit();
}

void DebugFile::deinit()
{
if( file && file.get() != &std::cerr ) {
output_repetitions( *file );
Expand Down Expand Up @@ -827,7 +821,7 @@ void setupDebug( DebugOutput output_mode )

void deinitDebug()
{
debugFile().deinit();
DebugFile::instance().~DebugFile();
}

// OStream Operators {{{2
Expand Down