Fix GCC 9: initialize to nullptr
#73473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Crafting / Construction / Recipes
|
Random test failure and I initialized only one of two vars. Shame that the test didn't run. Will fix when I get home. |
|
Omg, it is GCC 9, not Clang 9. |
github-actions
bot
added
the
BasicBuildPassed
|
It looks ok now. Ready to merge. |
|
Note: I think I did see that fail but confused it with an existing fail state. Thanks for the work you do! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
#73400 broke tests, I believe this is what
ClangGCC, Curses, LTO 9 wantsDescribe the solution
initialize to
nullptr. So it is still undefined behaviour, but at least the value is initialized.Describe alternatives you've considered
Ask if this is correct.
Testing
Let's see it compile
Broken tests in #73400 https://github.com/CleverRaven/Cataclysm-DDA/actions/runs/8927978126/job/24523240306
Fixed tests here https://github.com/CleverRaven/Cataclysm-DDA/actions/runs/8946092853/job/24576537951?pr=73473
Additional context
Mergers always surprise me with their sudden speed. I should have written "Do not merge yet!" before I went to sleep when I noticed it. Instead of relying on the merger to go through all the tests.