Start removing JsonIn by supporting a more verbose deserialize() pattern.
#51449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akrieger
force-pushed
the
start_removing_jsonin
branch
from
466c237 to
6e14a2b
Compare
actual-nh
added
[C++]
akrieger
force-pushed
the
start_removing_jsonin
branch
3 times, most recently
from
53f19ab to
9d3432b
Compare
To allow for incremental migration to JsonValue type deserialization, we can use the void_t detector pattern to enable one of two overloads for JsonIn::read(), one which calls a member deserialize function that takes JsonIn like before, and one which calls it with JsonValue. This way we can directly migrate types to using a JsonValue derived deserialize function without an intermediate state which has both old and new function signatures present.
Most instances of deserialize instantly convert from JsonIn to the object oriented interface, usually JsonObject. Using the improved interface on JsonIn we can change the signatures on these to more accurately reflect what they're doing. Also help get rid of JsonIn which is not supported in the binary json refactor this unblocks.
akrieger
force-pushed
the
start_removing_jsonin
branch
from
9d3432b to
006c10b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Infrastructure "Support deserialize directly from JsonObject/Array/Value/etc"
Purpose of change
JsonInis deprecated in #50143, which converts json loading from text to binary. Unfortunately, the entiredeserialize()pattern requires acceptingJsonInas an argument. To make that change more feasible we should do as much ahead-of-time removal ofJsonInas possible.Describe the solution
Many of the existing uses of
JsonInin thedeserialize()pattern just immediately convert to aJsonObjectorJsonArray, dropping into the 'object oriented'deserializepattern off the streaming patten. We can extendJsonIn::read()to support types with adeserializemethod taking eitherJsonInorJsonValue-convertible types. Then we can push the actual used type into the signature and remove a large number of unnecessary references toJsonIn.Describe alternatives you've considered
Supporting
JsonInon top ofFlexBufferswas attempted and discarded as discussed on #50143.Testing
CI, loaded and created games.