Ability to configure user-defined map extra symbols #48794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basic UI (uilist-driven)
But prompt the user on exit if all auto notes are disabled to enable them, when auto notes (map extras) are enabled. UI doesn't fit "(map extras)" clarification. In any case, at the moment only the map extras auto notes are configured in this window.
Maleclypse
added
Info / User Interface
kevingranade
reviewed
Jul 9, 2021
kevingranade
reviewed
Jul 9, 2021
actual-nh
added
0.F Backport Candidate
<Enhancement / Feature>
ZhilkinSerg
added a commit
to ZhilkinSerg/Cataclysm-DDA
that referenced
this pull request
Aug 12, 2021
ZhilkinSerg
added a commit
that referenced
this pull request
Aug 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Features "Implemented user defined map extra symbols"
Purpose of change
Continue #39430.
Provide a basic GUI for customizing user-defined map extra symbols requested in #38648.
Describe the solution
Map a hotkey to
CHANGE_MAPEXTRA_CHARACTERaction.Add data structures and methods to manipulate user-defined map extra symbols.
Saving and loading of user-defined map extra symbols.
Implement basic UI.
Describe alternatives you've considered
Not allowing user to set custom symbols and remove unused action
CHANGE_MAPEXTRA_CHARACTER.Testing
Remap several symbols in Auto note manager.
Save changes.
Newly discovered map extras got new symbols.
Custom symbols correctly loaded after restart.
Additional context
Non-ASCII symbols are still unsupported.
Please check new strings for any errors.
Screenshots:
Manager
Symbol prompt
Color picker
Overmap with user-defined map extra symbols
Disabled auto notes (map extras) state
On exit prompt
