Clarify unknown NPC error in mapgen #45547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This error occurs when the game is supplied an invalid npc_template for `place_npcs` in a mapgen entry. However, it says it was supplied an invalid npc class, which is a separate type, leading to confusion. Also, stick the thing it's having a problem with there, just for redundancy.
anothersimulacrum
added
the
[C++]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
This error occurs when the game is supplied an invalid npc_template for
place_npcsin a mapgen entry. However, it says it was supplied an invalid npc_class, which is a separate type, leading to confusion. Also, stick the thing it's having a problem with there, just for redundancy.Describe the solution
Change error message string.
Testing