Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CR] Interface: NewCharacter - Add responsive screen behavior for small terminal sizes #45438

Merged
merged 2 commits into from
Nov 21, 2020

Conversation

Pupsi-Mupsi
Copy link
Contributor

@Pupsi-Mupsi Pupsi-Mupsi commented Nov 15, 2020

Summary

SUMMARY: Interface "NewCharacter - Add responsive screen behavior for small terminal sizes"

Purpose of change

@ZhilkinSerg already paved the way in #45342.
This changes NewCharacter-Menu to be more responsive, especially with really small screens (terminal size of 80x25).
You won't see any difference on larger screens. Much like modern websites handle different devices and screen sizes.
It's not perfect yet. But it's a start, and it's definitely an improvement.

Testing

  • Compiled using microsoft visual studio 2019.
  • Checked that everything is working as expected.

Screenshot(s)

Before:

grafik

After:

grafik

Before:

grafik

After:

grafik

@Aivean Aivean added [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. labels Nov 15, 2020
@Pupsi-Mupsi
Copy link
Contributor Author

Too bad AppVeyor isn't up and running. Really don't wanna mess up anything.

@anothersimulacrum
Copy link
Member

If you're using VS, I'd be least worried about appveyor not working, it's also testing VS. The other tests are more important because they aren't testing similarly to you.

@kevingranade kevingranade merged commit d4a0263 into CleverRaven:master Nov 21, 2020
@Pupsi-Mupsi Pupsi-Mupsi deleted the PM-nc-resp1 branch November 21, 2020 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants