IWYU for tests #42806
Merged
IWYU for tests #42806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anothersimulacrum
added
[C++]
kevingranade
commented
Aug 9, 2020
jbytheway
reviewed
Aug 11, 2020
| #include "cata_generators.h" | ||
| #include "stringmaker.h" |
There was a problem hiding this comment.
There are a few places where you've removed stringmaker.h. This specializes some templates to customize Catch2 output and should remain. I don't think there's any way for IWYU to know this so I guess it will have to get a pragma everywhere we include it.
Don't know whether you want to go to the trouble of reverting this now, but it's something to bear in mind for the future if you run IWYU again or see {?} printed out in test results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Still chasing down build overhead from includes.
Describe the solution
Ran IWYU across tests and lightly edited the results.
Testing
Build and hopefully some teensy CBA improvements.