Add forward declarations for units.h, remove it from creature.h #42701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should allow removing units.h from some headers, and speeding up build times.
anothersimulacrum
added
[C++]
Hopefully this has some impact.
Fris0uman
pushed a commit
to Fris0uman/Cataclysm-DDA
that referenced
this pull request
Aug 6, 2020
….h (CleverRaven#42701)" This reverts commit dc1d68e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Should allow removing units.h from some headers, and speeding up build times.
Describe the solution
Add forward declarations for all of the
units::types in a separate header file, allowing that to be included instead of the full units.hTesting
Compiles.
Additional context
Some more headers could probably lose units.h, I just don't know which ones.