Overhaul lifting quality handling #41300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes inclusion of units.h from game_constants.h
mlangsdorf
approved these changes
Jun 14, 2020
mlangsdorf
added
Code: Build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Continuing to pick away at build time issues as surfaced by #41237
This one is an unnecessary inclusion of units.h in game_constants.h, which is included in many other modules (about a hundred) and is otherwise very lightweight.
Describe the solution
Moved the defines for weights to modules that aren't included and already include units.h
Along the way, I think it slightly improves understandability by hiding the quality number itself.
Describe alternatives you've considered
There's a lot more cleanup and rationalization of this code that could happen, but I'm trying to focus on the build time thing.
Testing
CBA should show some improvement, though game_constants.h and units.h didn't show up at the top of the list.
Verify that vehicle jacking and part lifting is still working as expected.