-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block bound inventory keys from auto assignment #40288
Block bound inventory keys from auto assignment #40288
Conversation
will that also happen if you don't have hjkl assigned? Maybe it should be linked to the buttons you have for movement. Some prefer even WASD |
This should block any keys currently bound to menu navigation. |
agreed, or even custom movement keys for those with an exotic keyboard layout (in my case I move with |
Who has familiarity with the inventory input code? I looked at it, and I could not figure out how to find the relevant keybindings in a reasonable amount of time. |
83e331c
to
ab9a024
Compare
This is almost certainly the wrong way; someone more qualified really ought to look at this.
ab9a024
to
90140e6
Compare
Co-authored-by: anothersimulacrum <anothersimulacrum@gmail.com>
Co-authored-by: Curtis Merrill <curtis.r.merrill@gmail.com>
Summary
SUMMARY: Interface "Block bound inventory keys from auto assignment"
Purpose of change
It is very annoying when auto inventory letter assignment assigns over your preferred navigation keys.
Describe the solution
Check if the letter is bound to an inventory action before automatically assigning it.
Describe alternatives you've considered
Testing
Additional context
Favorites and auto inventory letters seem to currently be in a bad state, so testing is limited.
Changing your key bindings after the letters have already been assigned doesn't work well. I managed to finagle it into doing the right thing by manually unassigning everything, stripping naked, and picking everything back up again.