Use qualified name lookup with has_artifact_with() calls #40247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request fixes 1 alert when merging 2a6f66f into 3fc82b4 - view on LGTM.com fixed alerts:
|
This was referenced May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
LGTM reports that these invocations are problematic specifically when recalc_sight_limits() is invoked from the player constructor and its subclass constructors. Specifically when called from the npc constructor, this is actually dispatching to Character::has_artifact_with() instead of npc::has_artifact_with(), which is not normally expected.
Describe the solution
Use qualified name lookup to make it clear that Character::has_artifact_with() is being called.
Describe alternatives you've considered
I looked into refactoring this in such a way that we could call npc::has_artifact_with() when called from the npc constructor, but I could not find a way to do it that wasn't terribly invasive and/or unclear.
Testing
Arrange to spawn a NPC with a clairvoyance artifact and...?
I expect LGTM to report the removal of an alert.