Make point and tripoint abs functions into methods. #40106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevingranade
commented
May 3, 2020
kevingranade
commented
May 3, 2020
kevingranade
commented
May 4, 2020
kevingranade
commented
May 4, 2020
kevingranade
commented
May 4, 2020
kevingranade
commented
May 4, 2020
jbytheway
reviewed
May 4, 2020
| @@ -72,6 +72,12 @@ struct point { | |||
| return point( x / rhs, y / rhs ); | |||
| } | |||
|
|
|||
| #ifndef CATA_NO_STL | |||
| inline point abs() const { | |||
There was a problem hiding this comment.
inline is redundant; definitions inside the class definition are implicitly inline.
There was a problem hiding this comment.
Gah, the whole mandatory inline thing for non-members keeps tripping me up, will fix.
This was referenced May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
As a minor cleanup, avoid using an essentially reserved keyword "abs" in the global namespace.
Describe the solution
Create point::abs() and tripoint::abs() and use them instead of abs( point ) and abs( tripoint ).
Describe alternatives you've considered
Renaming from abs to something else.
Namespacing the functions.
Ignoring it.
Testing
If it builds it should be fine.