Fix crash when NPC gives player equipment #39238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
<Bugfix>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix crash when NPC gives player equipment"
Purpose of change
Fixes #39186. According to the crash log the pure virtual function handler was called. Since the related classes do not call any virtual functions in their ctor or dtor the problem was probably a use-after-free. And it turned out that the code to randomly select an item from NPC inventory erases an item even if it's the selected item.
Describe the solution
Do not erase the selected item.
Testing
Debug spawned a few NPCs, traded with them so their inventory contains only two items, and modified their owed status to a high positive number so they were willing to share, and asked them to share equipment. The game no longer crashed after the fix.