Convert mapgen.h functions to use point #39229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Working towards #32017.
Towards clearer, more type-safe APIs.
Describe the solution
Convert various
mapgen.hfunctions from separateintarguments topoints.Testing
Unit tests only. Changes largely automated.
Additional context
This adds even more
NOLINTNEXTLINE(cata-use-named-point-constants)comments. There are more than I would prefer of them now, scattered throughout the codebase. I have some tentative plans to tweak that check to reduce the need for them, but it's on the back burner. If they're being especially annoying to others, let me know and I can prioritize.