npc: only report attitude changes that the avatar can see #37896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple fix to stop the player from seeing attitude changes for NPCs that the avatar cannot see.
mlangsdorf
added
<Bugfix>
|
Fixes #37415? |
|
Sure, let's go with that. |
This was referenced Feb 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "npc: only report attitude changes that the avatar can see"Purpose of change
Fixes #37415
NPCs that spawn near to the avatar but out of sight and are scared of the avatar will cause a message to appear in the message log, "$NPCname gets scared!" The player shouldn't get this information unless the avatar can see the NPC in question. Add a condition to the if test that
reports the change to make sure the avatar can see the NPC.
Describe the solution
It's just
&& g->u.sees( *this ); this is not super complicated.