Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pry one to items containing hammers #27918

Merged
merged 1 commit into from
Jan 28, 2019

Conversation

ifreund
Copy link
Contributor

@ifreund ifreund commented Jan 27, 2019

Summary

SUMMARY: Bugfixes "Add pry 1 to all items containing hammers."

Purpose of change

Extension of #27914. Realized today that toolbox wasn't the only item missing pry 1.

Additional context

@jbytheway makes a good point.

Fixes like this seem to keep happening. It would be great if someone could add unit tests to ensure that the toolbox (and similar items like the survivor utility belt) have qualities matching their ingredients.

We could really use some unit testing for recipes with tools as components.

@FuelType-Memes
Copy link
Contributor

We could really use some unit testing for recipes with tools as components.

With the new system of food inheriting properties of its components maybe have something similar for the recipes like toolbox and survivor's toolbelt? I've seen a lot of PR's adding new qualities to those items when the component's qualities change. Something along the lines of "copy-from" but "inherit-from"?

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact <Bugfix> This is a fix for a bug (or closes open issue) labels Jan 28, 2019
@ZhilkinSerg ZhilkinSerg merged commit e1e4791 into CleverRaven:master Jan 28, 2019
@ifreund ifreund deleted the add-pry-to-hammer-recipes branch February 5, 2019 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants