IWYU support (part 4): Fix release builds #27788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The <chrono> header here is used only in RELEASE mode, so IWYU run with debug mode options will want to delete it. Guard the #include behind RELEASE as well so that it isn't removed.
main.cpp needs to include SDL_version.h rather than SDL.h. This change allows IWYU to leave it rather than forcing it to change.
ZhilkinSerg
added
[C++]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
The attempt at running IWYU led to some issues on release builds (see CI failures on #27713).
Describe the solution
<chrono>, which is only needed for release builds.main.cppfrom includingSDL_version.h.