Notes text in UI now the color of the note. #27709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Working on fixing the astyle problems. |
|
Jenkins rebuild |
OrenAudeles
reviewed
Jan 18, 2019
src/overmap_ui.cpp
Outdated
| @@ -616,7 +616,8 @@ void draw( const catacurses::window &w, const catacurses::window &wbar, const tr | |||
| if( !note_text.empty() ) { | |||
| const size_t pos = std::get<2>( get_note_display_info( note_text ) ); | |||
There was a problem hiding this comment.
If you add a const std::tuple<char, nc_color, size_t> note_info = get_note_display_info( note_text ); above pos you can calculate the info once, making affected lines:
const size_t pos = std::get<2>( note_info ) and corner_text.emplace_back( std::get<1>( note_info ), note_text.substr( pos ) );
There was a problem hiding this comment.
Hmm that would be more efficient so that the info is only grabbed once and only one object is created. Ill add that and commit 😄
ZhilkinSerg
added
Info / User Interface
AMurkin
pushed a commit
to AMurkin/Cataclysm-DDA
that referenced
this pull request
Mar 4, 2019
Just like it did after CleverRaven#27709
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Interface "Changes text color to match map note color."Purpose of change
Found it odd that notes always display text in yellow. Was a simple change to allow it to use the note color.
Describe the solution
Display UI code now pulls note data for color along with the text.
Describe alternatives you've considered
Allow this to be configurable to either use standard yellow; note color; or other.