Plant seeding with vehicle #27491
Merged
Plant seeding with vehicle #27491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
[JSON]
mlangsdorf
approved these changes
Jan 8, 2019
kevingranade
approved these changes
Jan 8, 2019
|
I manually tested the change with success: using the tractor I was able to drive over the dirtmounds and seeds got placed in each tile. Or do you mean test coverage? |
|
I meant manual testing like that, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Allows vehicles with a seed-drill to plant seeds"Purpose of change
Fixes #27472
Describe the solution
Dirtmound recieves the NOCOLLIDE flag, so vehicles can drive over it.
The seed-drill vehicle part changes the ground to flat dirt when placing a seed (consistent with iexamine).
Additional context
Still WIP because one problem is not adressed: The seed-drill is supposed to be reloaded by examining it. Currently the context menu for reloading the seed-drill with seeds is missing.I will open a new Issue for that problem.