Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The imgui debug menu flickers in some cases, e.g resizing the window #77369

Open
NetSysFire opened this issue Oct 27, 2024 · 1 comment
Open
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Code: Debug Debugging and troubleshooting the game, also includes the debug menu ImGui Anything related to the new ImGui UI for SDL/tiles or ImTui for curses builds (S1 - Need confirmation) Report waiting on confirmation of reproducibility

Comments

@NetSysFire
Copy link
Member

Describe the bug

You can briefly see the game behind the menu.

Attach save file

n/a

Steps to reproduce

  1. Go into the debug menu.
  2. Select player > mutate (pM)
  3. Toggle any trait.
  4. It briefly flickers.

Alternatively, just resize the cdda window, e.g I make my window manager toggle fullscreen. That works with other menus such as the spawn item or monster one to cause flickering.

Expected behavior

It does not flicker/redraw the whole screen.

Screenshots

No response

Versions and configuration

  • OS: Linux
    • OS Version: LSB Version: n/a; Distributor ID: Arch; Description: Arch Linux; Release: rolling; Codename: n/a;
  • Game Version: cdda-experimental-2024-10-23-1516 99d27e5 [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Slowdown Fungal Growth [no_fungal_growth],
    Bionic Professions [package_bionic_professions]
    ]

Additional context

No response

@NetSysFire NetSysFire added (S1 - Need confirmation) Report waiting on confirmation of reproducibility [C++] Changes (can be) made in C++. Previously named `Code` Code: Debug Debugging and troubleshooting the game, also includes the debug menu ImGui Anything related to the new ImGui UI for SDL/tiles or ImTui for curses builds labels Oct 27, 2024
@CoroNaut
Copy link

#69987
I'm fairly certain that all windows redraw when they need an update, just in some cases, its slow. An example is the advanced inventory, any item that gets moved will toggle a complete redraw of the window. The consume window, when consuming an item, redraws the entire window. It makes sense that changing the color of a selection in the mutate window causes the game to re-get all items in the list. If it were just held in memory to change a single value, it would definitely be faster. The time is takes to completely get all the required information to display the window takes too long O(n).

A potential hack could be to wait to update the entire game UI until the window redraw is ready, rather than removing the window, calculating window contents, then redrawing window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Code: Debug Debugging and troubleshooting the game, also includes the debug menu ImGui Anything related to the new ImGui UI for SDL/tiles or ImTui for curses builds (S1 - Need confirmation) Report waiting on confirmation of reproducibility
Projects
None yet
Development

No branches or pull requests

2 participants