Spell menu gets squashed into ueslessness with long spell names

[Keltas]

Describe the bug

With the addition of hedge magic in the Xedra Evolved mod came magic squares and their long names. In particular the culprit here is "To Cause the Spirits to Bring us Anything We May Wish to Eat or to Drink". It stretches the name box so far that the information about the spell on the right is illegible.
Removing the spell in question makes the spell menu readable but still squashed a bit by the next longest name.

Attach save file

N/A

Steps to reproduce

Start the game as "XEDRA Operative, Department of Extra-Normal Capabilities, SATOR Division" who starts with the spell in question.

Expected behavior

For the spellbook box to either resize, to cut the long spell name short using ellipsis (...) or to continue on the next line.

Screenshots

Versions and configuration

• OS: Windows
  • OS Version: 10.0.19045.5011 (22H2)
• Game Version: ec0b796 [64-bit]
• Graphics Version: Tiles
• Game Language: System language []
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food],
  Portal Storms Ignore NPCs [personal_portal_storms],
  Slowdown Fungal Growth [no_fungal_growth],
  Magiclysm [magiclysm],
  Xedra Evolved [xedra_evolved],
  DinoMod [DinoMod],
  Megafauna [megafauna],
  Bombastic Perks [bombastic_perks],
  Keltas Mod [kelmod],
  Xedra Class Unrestriction [xedra_unrestriction],
  Useful Helicopters Experimental [useful_helicopters],
  Tamable Wildlife [Tamable_Wildlife],
  Mind Over Matter [mindovermatter],
  Martial Mastery [perk_melee_system]
  ]

Additional context

No response

[CLIDragon]

I imagine any fix will probably rely on #76513.

[Oleg-Pavlenko-EPAM]

No idea how exactly ImGUI works, but logically speaking, the right side of the dialog must have a minimum width (regardless of its layout) so that the labels and the scrollbar fit in. This would greatly drop the severity of the issue regardless of any other issues.

I'm also not quite sure why this dialog is so small in the first place and why can't it grow wider as spell names grow wider themselves, to a certain limit or cause...

Workaround. Right now to keep playing I have to mark all short spells as favorites, then once the dialog is opened, the width of the left & right columns doesn't change even when I switch tabs. Needless to say, spell names in the list are truncated, but at least I can fully see the descriptions, XP required for the next level, etc.

[db48x]

ImGui is quite extraordinarily flexible, because it relies on the user to implement whatever cleverness is required rather than trying to build all the cleverness in ahead of time.

The spell window is the size that it is merely because I used the same method of calculating a size that the previous implementation used. As I recall, it aims to be ⅜ of the width of the screen or 80 character cells wide, whichever is larger. Of course that makes more sense when the font in use is monospaced, but the main thing is that it tries to adjust to a comfortable size without being too wide on small screens. We can change it to pretty much anything you can think of though.

The main difference is just that the prior implementation had some explicit maximum width for the menu items which must have gotten lost in the shuffle. The current implementation lets the caller specify both the total window width and the width of the left and right preview panes (if needed), so it should use that information to clip the menu down to fit.

The logic will simply need to be adjusted slightly, probably around https://github.com/CleverRaven/Cataclysm-DDA/blob/master/src/ui.cpp#L788-L792. I’m sure I’ll get to it eventually, but it isn’t the highest priority bug on my list. I’d be happy to let someone else step in and fix it in the mean time.