Playing with kilograms, the game wants 20 pounds of salt in mission log.

[Brambor]

Describe the bug

Attach save file

N/A

Steps to reproduce

1. Have the Mass units option to kg.
2. Get the mission.
3. Look at it in the mission menu.
4. Observe that you will need to convert from pounds to kilograms.

Expected behavior

I want the game to translate it for me.

Screenshots

No response

Versions and configuration

• OS: Windows
  • OS Version: 10.0.19045.4412 (22H2)
• Game Version: 0.G-10098-g9e287b8451 [64-bit] - master was 5d0da40
• Graphics Version: Tiles
• Game Language: English [en]
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food],
  Portal Storms Ignore NPCs [personal_portal_storms],
  Slowdown Fungal Growth [no_fungal_growth]
  ]

Additional context

No response

[PatrikLundell]

/Confirmed (not that particular mission, but I've seen stupid pounds of some kind of metal sheets and gravel in the last week).

Doesn't really matter, since weight units are useless to the player anyway. The metric the player actually needs is the number of units. Fortunately, the cases I encountered had the number of units in the mission (but not the dialog).

There are really two issues here:

• Allow dialog and mission logs to respect the game unit settings (and then convert existing dialog to use the new functionality).
• Get mission authors to ensure the mission log (at least) specifies the number of items required so the player won't have to find an item, look at its weight (or volume, if there are any such cases), and then calculate the number of units required from that.

[RenechCDDA]

The simple way to resolve this: Change the description and mentions of "pounds" to something which is independent of measurement systems.

The good(?) way to resolve this: Some sort of json <tag> which resolves between weight measurements.

Here's links to the mentions in the JSON for anyone who wants a go.

Cataclysm-DDA/data/json/npcs/godco/godco_missions.json

Line 6 in 58b90c6

"description": "Find 20 pounds of salt.",

Cataclysm-DDA/data/json/npcs/godco/godco_missions.json

Line 16 in 58b90c6

"offer": "I know this doesn't sound important, but I am running low on salt. We don't just need it as a seasoning, it's also vital for food preservation. Could you find about 20 pounds of salt for me?",