Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto roof on "rock" construction results in natural rock roof #73316

Open
PatrikLundell opened this issue Apr 27, 2024 · 0 comments
Open

Auto roof on "rock" construction results in natural rock roof #73316

PatrikLundell opened this issue Apr 27, 2024 · 0 comments
Labels
Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Good First Issue This is a good first issue for a new contributor [JSON] Changes (can be) made in JSON (S2 - Confirmed) Bug that's been confirmed to exist

Comments

@PatrikLundell
Copy link
Contributor

PatrikLundell commented Apr 27, 2024

Describe the bug

The various constructed "rock" (in reality stone) terrain are defined to have a roof of t_rock_roof. However, t_rock_roof is described as natural rock, not something you can construct atop a wall made of stones.

Attach save file

N/A. It's JSON definitions.

Steps to reproduce

  1. Search the json files for e.g. the definition of t_drystone_wall data/json/furniture_and_terrain/terrain-walls.json).
  2. Examine the "roof" element.
  3. Locate the definition of "t_rock_roof" and find it's described as natural rock.

Expected behavior

Roofs on top of man made structures should be man made, not magically transformed into natural rock.

I don't know what the appropriate kind of roof for a stone wall to be. It could be one of the roof types already defined, or the ambitious could define a new type of stone roof.

Screenshots

No response

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.19045.4291 (22H2)
  • Game Version: 0.G-9089-g150fdfe843 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Portal Storms Ignore NPCs [personal_portal_storms],
    Slowdown Fungal Growth [no_fungal_growth]
    ]

Additional context

Comments with advice as to what would be a suitable replacement are welcome.

@PatrikLundell PatrikLundell added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Apr 27, 2024
@Maleclypse Maleclypse added Good First Issue This is a good first issue for a new contributor (S2 - Confirmed) Bug that's been confirmed to exist [JSON] Changes (can be) made in JSON Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Good First Issue This is a good first issue for a new contributor [JSON] Changes (can be) made in JSON (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

No branches or pull requests

2 participants