Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when attempting to close the game and choosing Yes while a debug message is displayed #65244

Open
NetSysFire opened this issue Apr 22, 2023 · 2 comments
Labels
<Crash / Freeze> Fatal bug that results in hangs or crashes. (P4 - Low) Low priority issues: things which are e.g exotic, minor and/or hard to encounter (S2 - Confirmed) Bug that's been confirmed to exist

Comments

@NetSysFire
Copy link
Member

NetSysFire commented Apr 22, 2023

Describe the bug

See description.

Attach save file

n/a

Steps to reproduce

There are two, potentially different issues here.

  1. Make sure you get a debugmsg while loading a world. In my case it was placing an item into a non-cargo space on a vehicle.
  2. Load your save.
  3. Send a SIGINT to the process (aka ctrl+c) while the debug message is displayed.
  4. A y/n box will be displayed. Choose yes to exit the game without saving (why is this even displayed when the save is still loading?).
  5. Segfault.

While trying to test around a bit to see if it impacted debug messages (by using a test debugmsg from the debug menu and ctrl+c'ing again) in general, I got the same crash but it looks like a different cause. While the above simply segfaults, I get

Fatal glibc error: malloc.c:2593 (sysmalloc): assertion failed: (old_top == initial_top (av) && old_size == 0) || ((unsigned long) (old_size) >= MINSIZE && prev_inuse (old_top) && ((unsigned long) old_end & (pagesize - 1)) == 0)

with this one. I can reproduce this reliably by teleporting outside (or probably just moving) and, emitting a debugmsg, ctrl+c'ing and choosing Yes. Sometimes this one works as expected, on the third try I got:

 free(): invalid size

Expected behavior

No crash, duh. Since this is a rather specific crash, I made this one low priority.

Screenshots

No response

Versions and configuration

  • OS: Linux
    • OS Version: LSB Version: n/a; Distributor ID: Arch; Description: Arch Linux; Release: rolling; Codename: n/a;
  • Game Version: 060fe4f [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Portal Storms Ignore NPCs [personal_portal_storms],
    No Fungal Growth [no_fungal_growth],
    Bionic Professions [package_bionic_professions]
    ]

Additional context

No response

@NetSysFire NetSysFire added <Crash / Freeze> Fatal bug that results in hangs or crashes. (S1 - Need confirmation) Report waiting on confirmation of reproducibility (P4 - Low) Low priority issues: things which are e.g exotic, minor and/or hard to encounter labels Apr 22, 2023
@GuardianDll
Copy link
Member

Segfault can also happen when you simply close the game when debug message on

@Qrox
Copy link
Contributor

Qrox commented Apr 23, 2023

Not sure if it's related, but the ctrl-c prompt is using query_yn which in turn uses ui_adaptor which is bound to cause all kinds of nasty reentry bugs. It might be best to write a special UI for the prompt that bypasses the ui_adaptor system, similar to the small console warning prompt.

@NetSysFire NetSysFire added (S2 - Confirmed) Bug that's been confirmed to exist and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Apr 23, 2023
@NetSysFire NetSysFire changed the title Crash when ctrl+c'ing and choosing Yes while a debug message is displayed Crash when attempting to close the game and choosing Yes while a debug message is displayed Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Crash / Freeze> Fatal bug that results in hangs or crashes. (P4 - Low) Low priority issues: things which are e.g exotic, minor and/or hard to encounter (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

No branches or pull requests

3 participants