Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow scenarios to specify starting weather. #63444

Open
DoctorBoomstick opened this issue Feb 5, 2023 · 6 comments
Open

Allow scenarios to specify starting weather. #63444

DoctorBoomstick opened this issue Feb 5, 2023 · 6 comments
Labels
Help Wanted Not particularly urgent or easy (see Good First Issue for this), but help is appreciated with this! Mechanics: Weather Rain, snow, portal storms and non-temperature environment (P4 - Low) Low priority issues: things which are e.g exotic, minor and/or hard to encounter <Suggestion / Discussion> Talk it out before implementing

Comments

@DoctorBoomstick
Copy link
Contributor

Is your feature request related to a problem? Please describe.

When making a new scenario, there are a number of things one may do to make it interesting, such as customizing the time, spawn location, and applying effects. However, one of the elements beyond the scope of scenarios is specifying a particular type of weather that the game starts with. This evidently holds through for EOCs from what I’ve been told, and is, in my personal view, a slight shame as determining the weather can lead to some interesting scenario ambiences, as well as opening the door to new ideas.

Solution you would like.

I’d suggest allowing weather effects to be prompted through EOCs to leave room for interesting ingame uses as well as for utility in scenarios, or simply allowing the type of desired weather to be specified in the scenario json.

Describe alternatives you have considered.

No response

Additional context

No response

@DoctorBoomstick DoctorBoomstick added the <Suggestion / Discussion> Talk it out before implementing label Feb 5, 2023
@ZhilkinSerg
Copy link
Contributor

@DoctorBoomstick
Copy link
Contributor Author

From what I’ve been told, it looks like both the “cause_portal_storm” and “cause_dust_storm” EOCs hinge on all their starting variables being set by the EOC in question. For weather to similarly be caused, such as a thunder storm, an EOC would have to set up precipitation and other weather values to prompt the start of a weather change: something that can’t be done at the present.

@GuardianDll
Copy link
Member

Right, as you may expect from its name, next_weather do not force the game to change the weather to some picked, it force the game to see what another weather it can pick, and pick it. Both dust storm and portal storm has no another conditions except few variables, when to start, for example, rainstorm, you need to have temperature more than 33, and wind speed more than 15 (https://github.com/CleverRaven/Cataclysm-DDA/blob/master/data/json/weather_type.json#L153)
Without a way to force or avoid this checks, the game will simply find it can't apply them, and casually reject them.

@Ramza13
Copy link
Contributor

Ramza13 commented Feb 7, 2023

Ok so its awkward but you could just add an or condition to the weather you want to force with a variable. So for example rainstorm is either temp > 33 and wind >15 or is_rain = 1. Then set the variable for as long as you like and boom. A bit complicated but doable.

@NetSysFire NetSysFire added Mechanics: Weather Rain, snow, portal storms and non-temperature environment Help Wanted Not particularly urgent or easy (see Good First Issue for this), but help is appreciated with this! labels Feb 7, 2023
@JonathanLochridge
Copy link
Contributor

I agree this would be cool to have. After reading this I already have a couple ideas of how I could use this if we had it.
Most notably making a winter start that makes you start in the wilderness in the middle of a blizzard. So, that finding shelter or a source of warmth is essential to not die to the cold. (Although, spawning with someone with warmer equipment could give you a little bit of a margin.)

@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Apr 2, 2023
@Procyonae Procyonae added (P4 - Low) Low priority issues: things which are e.g exotic, minor and/or hard to encounter and removed stale Closed for lack of activity, but still valid. labels Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Not particularly urgent or easy (see Good First Issue for this), but help is appreciated with this! Mechanics: Weather Rain, snow, portal storms and non-temperature environment (P4 - Low) Low priority issues: things which are e.g exotic, minor and/or hard to encounter <Suggestion / Discussion> Talk it out before implementing
Projects
None yet
Development

No branches or pull requests

7 participants