Typing in the mobile version of the game is inconsistent

[gettingusedto]

Describe the bug

Typing in the mobile port with the on-screen keyboard is quite inconsistent. Some works as expected, like searching for a recipe in the crafting menu, meanwhile typing a letter in the diary screen closes my on-screen keyboard, making me press my "back" button to deploy the on-screen keyboard back and type another letter.

Steps to reproduce

1. play the mobile port
2. get into a world
3. open up the diary
4. edit text
5. agony

Expected behavior

On-screen keyboard not retracting every time i press a letter.

Screenshots

No response

Versions and configuration

• OS: Android
  • OS Version: Manufacturer: samsung; Model: SM-A710F; Release: 7.0; Incremental: A710FXXU2CRC2;
• Game Version: 65e5b97 [32-bit]
• Graphics Version: Tiles
• Game Language: System language []
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food],
  No Fungal Growth [no_fungal_growth],
  Magiclysm [magiclysm],
  Misc Sprites [misc_sprite],
  Misc Sprites: Magiclysm Edition [misc_sprite_magiclysm],
  Crow's Hairstles 2: Ears and Tails [hairmod2_earsAndTails],
  Portal Gatcha Mod [GATCHA_Portal],
  Stats Through Skills [StatsThroughSkills]
  ]

Additional context

I assume using physical keyboard didn't have this issue since the issue is that the on-screen keyboard retracting back when a letter pressed in certain places.

[WreckingAbandon]

I think there's an option to turn that off, the "auto-manage virtual keyboard" in the Android tab in the options.

[gettingusedto]

Ah, it works as expected now, though it's weird that turning on "auto-manage virtual keyboard" makes it acts weirdly in certain places.

[Qrox]

I think this is probably what is happening: the following code tries to close virtual keyboard automatically in non-text-input UIs:

Cataclysm-DDA/src/sdltiles.cpp

Lines 2727 to 2734 in d1f765d

	// If we were in an allow_text_entry input context, and text input is still active, and we're auto-managing keyboard, hide it.
	if( touch_input_context.allow_text_entry &&
	!new_input_context->allow_text_entry &&
	!is_string_input( *new_input_context ) &&
	SDL_IsTextInputActive() &&
	get_option<bool>( "ANDROID_AUTO_KEYBOARD" ) ) {
	StopTextInput();
	}

However, it uses hardcoded ids to tell whether a context is text input or not:

Cataclysm-DDA/src/sdltiles.cpp

Lines 2519 to 2526 in d1f765d

	bool is_string_input( input_context &ctx )
	{
	std::string &category = ctx.get_category();
	return category == "STRING_INPUT"
	|| category == "HELP_KEYBINDINGS"
	|| category == "NEW_CHAR_DESCRIPTION"
	|| category == "WORLDGEN_CONFIRM_DIALOG";
	}

Which is missing the id of the string editor window's input context:

Cataclysm-DDA/src/string_editor_window.cpp

Lines 280 to 282 in d1f765d

	void string_editor_window::create_context()
	{
	ctxt = std::make_unique<input_context>( "STRING_EDITOR", keyboard_mode::keychar );

I see two problems here: first, the string editor window's input context should be considered a text input context; second, whether an input context is text input should be provided by the respective UI code (using allow_text_entry?) instead of hardcoded.

Also, it seems the first code snippet is supposed to close virtual keyboard when switching between contexts, but for some reason it closes virtual keyboard every time a key is pressed in the same context.

[I-am-Erk]

How hard is this to fix, @Qrox? If it's going to be a big one, I won't add it to blockers, but if you think it's fairly easy we should try to resolve it I think.

[Qrox]

I haven't tested, but the easiest fix is probably adding "STRING_EDITOR" to the conditions in is_string_input. Refactoring the code to specify allow_text_entry in the respective UI code also seems straightforward. The underlying problem might be trickier to pinpoint but that can be done after 0.G.