Skip to content

New mutation system can't cancel/overwrite base traits #55959

Open
@42Forty2

Description

Describe the bug

The new mutation system behaves weirdly with regards to traits taken at chargen. They upgrade well enough, but trying to overwrite them seems impossible. It either doesn't pop (when trying to cancel a negative trait) or keeps both the positive AND negative version of the trait (if the positive was taken at chargen).

Steps to reproduce

  1. Spawn new character with base traits that Mutations can cancel (eg Ugly, Strong Back, or Slow Healer) or have otherwise conflicting traits of the same type (eg Fast Metabolism)
  2. Try debug Mutating into a trait that cancels it (eg Pretty, Bad Back, Regeneration, Persistence Hunter)
  3. It either doesn't pop or keeps both traits.

Expected behavior

Players should be able to mutate out of Traits taken at chargen.

Screenshots

No response

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.19043.1526 (21H1)
  • Game Version: b6afc5a [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Bionic Professions [package_bionic_professions],
    Bionic Slots [cbm_slots],
    Stats Through Kills [stats_through_kills],
    Disable NPC Needs [no_npc_food],
    No Fungal Growth [no_fungal_growth],
    Forty's Small Mod [42_small_mod],
    Extra Mutated Scenarios [extra_mut_scens],
    No Rail Stations [No_Rail_Stations]
    ]

Additional context

Json for mutations from my personal build of Forty's Small Mod (42sm_mutations):

[
  {
    "//": "Balance tweak: Junkfood is a prevalent early-game food, so taking it at chargen is worth the extra point.",
	"type": "mutation",
	"id": "ANTIJUNK",
	"copy-from": "ANTIJUNK",
	"points": -2
  },
  {
    "type": "mutation",
    "id": "EAGLEEYED",
	"copy-from": "EAGLEEYED",
	"extend": {
		"category": [ "ELFA" ],
		"changes_to": [ "FEYEYES" ]
	}
  },
  {
	"//": "Quick aside - cannot stop thinking 'you got a purdy mouth' when looking at base HUMAN_MOUTH's types",
	"type": "mutation",
	"id": "HUMAN_MOUTH",
	"copy-from": "HUMAN_MOUTH",
	"types": [ "TEETH", "MUZZLE" ]
  },
  {
    "//": "An attempt to fix the issue for Pretty/Ugly under the assumption that my Fangs starting trait was the problem. Not the case.",
	"type": "mutation",
    "id": "HUMAN_BEAUTY",
    "name": { "str": "Plain Jane" },
    "points": 0,
    "player_display": false,
	"category": [ "HUMAN" ],
	"types": [ "ATTRACTIVENESS" ],
	"description": "You look normal, neither deformed nor drop-dead gorgeous."
  },
  {
    "//": "If genetically modified catgirls and wolfbuys wasn't officially one of XEDRA's goals, then what was the point of it all?",
	"type": "mutation",
    "id": "PRETTY",
	"copy-from": "PRETTY",
	"extend": {
		"category": [ "FELINE", "LUPINE" ]
	}
  },
  {
    "//": "Bugfix - base Rosebuds has no scentmask while Flowering does, making it a downgrade.",
	"type": "mutation",
    "id": "ROSEBUDS",
	"name": { "str": "Rosebuds" },
	"copy-from": "ROSEBUDS",
	"scent_mask": -300,
    "social_modifiers": { "lie": 15, "persuade": 10 }
  },
  {
	"type": "mutation",
    "id": "FEYEYES",
    "name": { "str": "Fey Scout" },
    "points": 4,
    "description": "Legolas, what do your Elf Eyes see? Even the keenest of human eyes cannot hope to best your ability to spot distant landmarks, further extending your sight range on the overmap. Also Perception +2",
	"prereqs": [ "EAGLEEYED" ],
    "prereqs2": [ "ELFAEYES" ],
    "threshreq": [ "THRESH_ELFA" ],
    "category": [ "ELFA" ],
    "cancels": [ "MYOPIC", "UNOBSERVANT" ],
    "overmap_sight": 10,
	"passive_mods": { "per_mod": 2 }
  }
]

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions