Enable performance-inefficient-vector-operation (#48480)

* Add a collection of `vector::reserve` calls.

All changes done automatically by clang-tidy.

* Enable performance-inefficient-vector-operation

.clang-tidy

@@ -36,7 +36,6 @@ readability-*,\
 -modernize-return-braced-init-list,\
 -modernize-use-default-member-init,\
 -modernize-use-emplace,\
--performance-inefficient-vector-operation,\
 -performance-implicit-conversion-in-loop,\
 -performance-inefficient-string-concatenation,\
 -performance-type-promotion-in-math-fn,\

src/activity_item_handling.cpp

@@ -2526,6 +2526,7 @@ static requirement_check_result generic_multi_activity_check_requirement( player
                 // come back here after successfully fetching your stuff
                 if( act_prev.coords.empty() ) {
                     std::vector<tripoint> local_src_set;
+                    local_src_set.reserve( src_set.size() );
                     for( const tripoint &elem : src_set ) {
                         local_src_set.push_back( here.getlocal( elem ) );
                     }

src/cata_tiles.cpp

@@ -3928,6 +3928,7 @@ std::vector<options_manager::id_and_option> cata_tiles::build_display_list()
     };
 
     int numdisplays = SDL_GetNumVideoDisplays();
+    display_names.reserve( numdisplays );
     for( int i = 0 ; i < numdisplays ; i++ ) {
         display_names.emplace_back( std::to_string( i ), no_translation( SDL_GetDisplayName( i ) ) );
     }

src/debug_menu.cpp

@@ -1956,6 +1956,7 @@ static void debug_menu_game_state()
     tripoint abs_sub = here.get_abs_sub();
     std::string mfus;
     std::vector<std::pair<m_flag, int>> sorted;
+    sorted.reserve( m_flag::MF_MAX );
     for( int f = 0; f < m_flag::MF_MAX; f++ ) {
         sorted.push_back( {static_cast<m_flag>( f ), MonsterGenerator::generator().m_flag_usage_stats[f]} );
     }
@@ -1984,6 +1985,7 @@ static void debug_menu_game_state()
 
     if( !creature_counts.empty() ) {
         std::vector<std::pair<std::string, int>> creature_names_sorted;
+        creature_names_sorted.reserve( creature_counts.size() );
         for( const std::pair<const std::string, int> &it : creature_counts ) {
             creature_names_sorted.emplace_back( it );
         }

src/faction_camp.cpp

@@ -532,6 +532,7 @@ recipe_id base_camps::select_camp_option( const std::map<recipe_id, translation>
     std::vector<std::string> pos_names;
     int choice = 0;
 
+    pos_names.reserve( pos_options.size() );
     for( const auto &it : pos_options ) {
         pos_names.push_back( it.second.translated() );
     }

src/inventory.cpp

@@ -449,6 +449,7 @@ void inventory::form_from_zone( map &m, std::unordered_set<tripoint> &zone_pts,
                                 bool assign_invlet )
 {
     std::vector<tripoint> pts;
+    pts.reserve( zone_pts.size() );
     for( const tripoint &elem : zone_pts ) {
         pts.push_back( m.getlocal( elem ) );
     }

src/item_contents.cpp

@@ -149,6 +149,7 @@ bool pocket_favorite_callback::key( const input_context &, const input_event &ev
         }
 
         std::vector<std::string> itype_initializer;
+        itype_initializer.reserve( nearby_itypes.size() );
         for( const std::pair<const std::string, const itype *> &name : nearby_itypes ) {
             itype_initializer.emplace_back( name.first );
         }

src/magic_spell_effect.cpp

@@ -1229,6 +1229,7 @@ void spell_effect::dash( const spell &sp, Creature &caster, const tripoint &targ
     ::map &here = get_map();
     // uses abs() coordinates
     std::vector<tripoint> trajectory;
+    trajectory.reserve( trajectory_local.size() );
     for( const tripoint &local_point : trajectory_local ) {
         trajectory.push_back( here.getabs( local_point ) );
     }

src/mission_companion.cpp

@@ -2054,6 +2054,7 @@ npc_ptr talk_function::companion_choose_return( const tripoint_abs_omt &omt_pos,
     }
 
     std::vector<std::string> npcs;
+    npcs.reserve( available.size() );
     for( auto &elem : available ) {
         npcs.push_back( ( elem )->name );
     }

src/newcharacter.cpp

@@ -1448,6 +1448,7 @@ tab_direction set_traits( avatar &u, points_left &points )
                 // Grab a list of the names of the bionics that block this trait
                 // So that the player know what is preventing them from taking it
                 std::vector<std::string> conflict_names;
+                conflict_names.reserve( cbms_blocking_trait.size() );
                 for( const bionic_id &conflict : cbms_blocking_trait ) {
                     conflict_names.emplace_back( conflict->name.translated() );
                 }

src/npc.h

@@ -177,6 +177,7 @@ class job_data
             const std::pair<activity_id, int> &b ) {
                 return a.second > b.second;
             } );
+            ret.reserve( pairs.size() );
             for( const std::pair<activity_id, int> &elem : pairs ) {
                 ret.push_back( elem.first );
             }

src/requirements.cpp

@@ -72,6 +72,7 @@ const requirement_data &string_id<requirement_data>::obj() const
 std::vector<requirement_data> requirement_data::get_all()
 {
     std::vector<requirement_data> ret;
+    ret.reserve( requirements_all.size() );
     for( const std::pair<const requirement_id, requirement_data> &pair : requirements_all ) {
         ret.push_back( pair.second );
     }

tests/encumbrance_test.cpp

@@ -61,6 +61,7 @@ static void test_encumbrance(
 {
     CAPTURE( clothing_types );
     std::vector<item> clothing;
+    clothing.reserve( clothing_types.size() );
     for( const std::string &type : clothing_types ) {
         clothing.push_back( item( type ) );
     }

tests/generic_factory_test.cpp

@@ -380,6 +380,7 @@ TEST_CASE( "string_and_int_ids_benchmark", "[.][generic_factory][int_id][string_
     }
     const int test_flags_size = test_flags.size();
     std::vector<dyn_str_id > test_dyn_str_ids;
+    test_dyn_str_ids.reserve( test_flags.size() );
     for( const auto &f : test_flags ) {
         test_dyn_str_ids.push_back( dyn_str_id( f.str() ) );
     }

tests/ranged_balance_test.cpp

@@ -117,6 +117,7 @@ static std::vector<firing_statistics> firing_test( const dispersion_sources &dis
         const int range, const std::vector< Threshold > &thresholds )
 {
     std::vector<firing_statistics> firing_stats;
+    firing_stats.reserve( thresholds.size() );
     for( const Threshold &pear : thresholds ) {
         firing_stats.push_back( firing_test( dispersion, range, pear ) );
     }

tests/string_ids_test.cpp

@@ -37,6 +37,7 @@ TEST_CASE( "string_ids_intern_test", "[string_id]" )
     struct test_obj {};
     std::vector<string_id<test_obj>> ids;
     // lots of ids to make sure that "interning" map gets expanded
+    ids.reserve( num_ids );
     for( int i = 0; i < num_ids; ++i ) {
         ids.push_back( string_id<test_obj>( "test_id" + std::to_string( i ) ) );
     }
@@ -119,6 +120,7 @@ TEST_CASE( "string_id_sorting_test", "[string_id]" )
 
     SECTION( "vector ids sorting" ) {
         std::vector<id> vec;
+        vec.reserve( 10 );
         for( int i = 0; i < 10; ++i ) {
             vec.push_back( id( "id" + std::to_string( i ) ) );
         }
@@ -150,6 +152,7 @@ TEST_CASE( "string_id_creation_benchmark", "[.][string_id][benchmark]" )
 {
     static constexpr int num_test_strings = 30;
     std::vector<std::string> test_strings;
+    test_strings.reserve( num_test_strings );
     for( int i = 0; i < num_test_strings; ++i ) {
         test_strings.push_back( "some_test_string_" + std::to_string( i ) );
     }