feat(cc-addon-*.smart-jenkins): init #1611
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeleneAmouzou
force-pushed
the
dashboard-addons/jenkins
branch
from
8a7b4b1 to
3aefac4
Compare
Contributor
|
🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/dashboard-addons/jenkins/index.html. This preview will be deleted once this PR is closed. |
Galimede
requested changes
Nov 17, 2025
Member
Galimede
left a comment
Galimede
left a comment
There was a problem hiding this comment.
Hey Hélène, thanks for the smart! 💪
Overall LGTM, there's just mostly nitpicks below, GG! 👏
src/components/cc-addon-header/cc-addon-header.smart-jenkins.md
Outdated
Show resolved
Hide resolved
src/components/cc-addon-header/cc-addon-header.smart-jenkins.js
Outdated
Show resolved
Hide resolved
src/components/cc-addon-header/cc-addon-header.smart-jenkins.js
Outdated
Show resolved
Hide resolved
| updateComponent('state', { | ||
| type: 'loaded', | ||
| version: { | ||
| stateType: 'up-to-date', |
Member
There was a problem hiding this comment.
question: I'm not sure to understand this up-to-date thing, are we always setting it to up-to-date because APIs currently don't provide this information?
Contributor
Author
There was a problem hiding this comment.
Some products can be updated by users, others can not, we set up-to-date for those that can not be updated by users
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
index.html,cc-addon-headerandcc-addon-infofor Jenkins product.How to review?
demo-smart.The
.mddocumentation files has been coded by IA, even though I have checked and adjusted afterwards, please pay attention to it.TO DO
ElasticPR is merge to removeElasticcommits.