Fix List Item width styling. #271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent change added 100% width to the list item contents, which extends it past its parent bounds. Issue wasn't visible in Dewey because there was a top-level `box-sizing: border-box` applied to all elements in Dewey. Took that out so that components build in Dewey don't make assumptions about the base styling clients are using.
kofi-clever
force-pushed
the
fix-list-items
branch
from
f41955a to
306e21f
Compare
kofi-clever
added a commit
that referenced
this pull request
Mar 19, 2018
Recent change added 100% width to the list item contents, which extends it past its parent bounds. Issue wasn't visible in Dewey because there was a top-level `box-sizing: border-box` applied to all elements in Dewey. Took that out so that components build in Dewey don't make assumptions about the base styling clients are using.
prime-time
pushed a commit
that referenced
this pull request
Mar 28, 2018
Recent change added 100% width to the list item contents, which extends it past its parent bounds. Issue wasn't visible in Dewey because there was a top-level `box-sizing: border-box` applied to all elements in Dewey. Took that out so that components build in Dewey don't make assumptions about the base styling clients are using.
mcab
pushed a commit
that referenced
this pull request
Apr 23, 2021
Recent change added 100% width to the list item contents, which extends it past its parent bounds. Issue wasn't visible in Dewey because there was a top-level `box-sizing: border-box` applied to all elements in Dewey. Took that out so that components build in Dewey don't make assumptions about the base styling clients are using.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: N/A
Overview:
Recent change added 100% width to the list item contents, which extends it past its parent bounds.
Issue wasn't visible in Dewey because there was a top-level
box-sizing: border-boxapplied to all elements in Dewey. Took that out so that components build in Dewey don't make assumptions about the base styling clients are using.Screenshots/GIFs:
Before:
After:
Testing:
Roll Out:
package.jsonnpm version minornpm version patchmake deploy-docs)