This repository was archived by the owner on Jun 24, 2022. It is now read-only.
Swagger-codegen library #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kvigen I updated this for 2.0. Want to give it another look? |
kvigen
approved these changes
Jan 2, 2018
clever/api_client.py
Outdated
| @@ -121,7 +121,7 @@ def __call_api(self, resource_path, method, | |||
| for k, v in path_params: | |||
| # specified safe chars, encode everything | |||
| resource_path = resource_path.replace( | |||
| '{%s}' % k, quote(str(v), safe=config.safe_chars_for_path_param)) | |||
There was a problem hiding this comment.
this isn't clever-specific, right? i wonder if we should try to fix this upstream?
There was a problem hiding this comment.
I'm not sure this is even a real thing... But it existed before so I'm keeping up the behavior
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated library from our swagger api file for v1.2.
Added in logic to handle our event types and a test for this.
Also ported over a test for handling unicode characters since this came up recently.
Major version bump.
This made me realize we had a CLI which is now gone :(