-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add zfs io counters for linux and freebsd #1248
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1248 +/- ##
==========================================
+ Coverage 31.84% 32.36% +0.51%
==========================================
Files 97 94 -3
Lines 16581 16293 -288
==========================================
- Hits 5281 5273 -8
+ Misses 11300 11020 -280
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Seems reasonable to add, I'll take a look in a bit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, just a few small comments.
Thanks for the feedback! I have tried to address your comments. Please let me know if more is needed. |
…ers and squash if statement in zfs_io_counters
Description
ZFS datasets in the disk menu lacked support for monitoring the read and written bytes.
This PR adds io-counters (read bytes and written bytes) for the named zfs datasets in the disks menu.
Screens:

Linux:
FreeBSD:

Testing
Tested on linux and freebsd, with and without zfs.
Checklist
If relevant, ensure the following have been met:
cargo fmt
)README.md
, help menu, doc pages, etc.)I did NOT test with an extensive zfs setup (no draid/raidz/spares) just my simple mirror pools (maybe use file backed pools to test?)
If any of the Issues should be addressed or a different approach used please let me know.
Feel free to close this PR if it is unwanted.