Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable zfs feature #1044

Merged
merged 1 commit into from
Mar 5, 2023
Merged

Conversation

jamartin9
Copy link
Contributor

@jamartin9 jamartin9 commented Mar 5, 2023

Description

Re-enable the zfs feature flag by default for deployment.
Show zfs arc stats when available on linux/freebsd.
The code and comments come from the removed heim memory backend.

(PR's for macos/windows zfs support are being reviewed upstream?)

Testing

Compiled on linux/freebsd.
Ran with basic and graph on linux/freebsd.
Ran with and without zfs enabled on linux/freebsd.

  • Windows
  • macOS
  • Linux
  • FreeBSD

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

Copy link
Owner

@ClementTsang ClementTsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks for catching this.

@codecov
Copy link

codecov bot commented Mar 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.32 ⚠️

Comparison is base (994c11e) 26.54% compared to head (1e9f9f9) 26.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1044      +/-   ##
==========================================
- Coverage   26.54%   26.22%   -0.32%     
==========================================
  Files          80       80              
  Lines       14574    14748     +174     
==========================================
  Hits         3868     3868              
- Misses      10706    10880     +174     
Flag Coverage Δ
macos-12 26.98% <0.00%> (-0.34%) ⬇️
ubuntu-latest 26.84% <0.00%> (-0.25%) ⬇️
windows-2019 26.69% <0.00%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/data_harvester/memory/sysinfo.rs 0.00% <0.00%> (ø)
src/data_conversion.rs 12.93% <0.00%> (-1.50%) ⬇️
src/app/data_farmer.rs 9.33% <0.00%> (-0.27%) ⬇️
src/canvas.rs 0.00% <0.00%> (ø)
src/app/data_harvester.rs 0.00% <0.00%> (ø)
src/canvas/widgets/mem_basic.rs 0.00% <0.00%> (ø)
src/canvas/widgets/mem_graph.rs 0.00% <0.00%> (ø)
src/bin/main.rs 37.50% <0.00%> (+0.17%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ClementTsang ClementTsang merged commit 3510563 into ClementTsang:master Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants