Tooltip & Hover Fix #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miozune
pushed a commit
to GTNewHorizons/ModularUI2
that referenced
this pull request
Aug 11, 2024
* fix tooltip ignoring transformations * fix parent widgets not being hovered when they get background from theme (cherry picked from commit 68d2799)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before tooltips ignored the widgets transformations. This caused the tooltip to be offset in scrolling widgets. Now the widgets transormations are applied when drawing widgets in foreground. This also means that you can no longer attach the tooltip to another widget or area
exclusionArea. The tooltip will now show up around the transformed widget without any transformations applied to it except the true pos and size of the widget.canHover()inParentWidgetreturns true when it as a background, hover background/overlay or tooltip. But some widgets like panels get their background from the current theme when they dont have any. This caused the widget to not be detected as hovered and instead could hover widgets below that widget. This pr fixes it by checking if the current widget theme has any background.Closes #54