Mixin #299
Draft
Mixin #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WaitingIdly
reviewed
Apr 9, 2025
examples/runConfig.json
Outdated
There was a problem hiding this comment.
should this be changed?
| @@ -19,6 +19,9 @@ public class GroovyScriptTransformer implements IClassTransformer { | |||
| @Override | |||
| public byte[] transform(String name, String transformedName, byte[] bytes) { | |||
| if (bytes == null) return null; | |||
| if (transformedName.contains("PlayerLoggedInEvent") || transformedName.endsWith("PlayerList") || transformedName.endsWith("EntityPlayerMP") || transformedName.endsWith("NetworkManager") || transformedName.endsWith("NetHandlerPlayServer") || transformedName.endsWith("TextComponentString")) { | |||
There was a problem hiding this comment.
i think this is debug code
src/main/java/com/cleanroommc/groovyscript/sandbox/MixinSandbox.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
should this stay in here? feels like test code
friendlyhj
reviewed
Jun 23, 2025
| IMixinConfig config = Config.create(cfgName, MixinEnvironment.getDefaultEnvironment()).getConfig(); | ||
| List<String> mixinClasses; | ||
| try { | ||
| Class<?> mixinConfigClass = Class.forName("org.spongepowered.asm.mixin.transformer.MixinConfig"); |
There was a problem hiding this comment.
why add mixinClasses by reflection? mixin has an API to add mixin class dynamically. IMixinConfigPlugin#getMixins
| return new ScriptEngine(SandboxData.getRootUrls(), SandboxData.getMixinScriptCachePath(), SandboxData.getScriptFile(), config) | ||
| .onClassLoaded(cc -> { | ||
| GroovyLog.get().info(" - loaded mixin class {} from cache", cc.getName()); | ||
| resourceCache.put(cc.getName(), cc.getData()); |
There was a problem hiding this comment.
We can not just put bytecodes to the cache. Some optimization mods (VintageFix & Loliasm) would set the cache to guava's cache that its content would be removed.
There was a problem hiding this comment.
How should i handle this instead? That where mixin finds the mixin class bytes
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.