Skip to content

Conversation

@Alexandre-Classiq
Copy link
Collaborator

PR Description

Including a new tutorial on quantum types and variables.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions
Copy link

github-actions bot commented Nov 18, 2025

🔥 New notebook just dropped!

@amir-naveh , @TomerGoldfriend — come check out this shiny new addition to our repo.

@Alexandre-Classiq Alexandre-Classiq force-pushed the alexandre-modeling-quantum-types-tutorial branch from 1e3a850 to d4e7fd5 Compare November 27, 2025 14:38
@@ -0,0 +1,725 @@
{
Copy link
Collaborator

@drorsegman drorsegman Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My high level comments:

  1. The exercises seem really good and helpful.
  2. We should more strictly stick to the model of: Tutorial is solely exercises (with links to user guide, hints and solutions).
  3. The diagrams you used to describe visually the different types look very helpful for users' understanding. I would keep them but not in the tutorial but in the user guide (and just make sure to add here links).

Do you think "workshop" is a more appropriate name to the exercises-only thing that I suggest here?

Also, I'm not sure we have to have identical structure for the user guide and workshop. I mean - maybe for explanation it is useful to have types separate from functions, but for hands on exercise it is more useful to mix them together (and just include good links to user guide).

Not sure about that, just pointing out the idea.

So, I'd say lets be more strict about the role of each documentation part (formal reference / user guide / workshop / docstring) but less strict about the unufied structure (let each part be structured in the most useful way for its purpose)


Reply via ReviewNB

@@ -0,0 +1,725 @@
{
Copy link
Collaborator

@drorsegman drorsegman Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This content is to be covered in the user guide, and only be linked from the tutorial.


Reply via ReviewNB

@@ -0,0 +1,725 @@
{
Copy link
Collaborator

@drorsegman drorsegman Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here also, these are good explainations, but they should be left in the user guide. here e only want excercises + hints and solutions


Reply via ReviewNB

@@ -0,0 +1,725 @@
{
Copy link
Collaborator

@drorsegman drorsegman Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A general comment for smoother review: Let's try to keep each content paragraph in its own notebook cell, so that when I add a comment it is clear to which text it refers.

Learning checklist - Like.


Reply via ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants