fix(exchange): restore the admin section shell — side menu + page bounds#664
Merged
Conversation
The TME admin pages were ported declaring layout: 'admin', but this app renders <NuxtPage> without <NuxtLayout>, so layouts never mount — the nine /admin/exchange pages rendered bare: no side navigation (sub-pages were unreachable) and no container bounds, unlike every other admin page. Add AdminExchangeShell (container + breadcrumb + section side menu with the moderation/message-queue badges ported from TME's drawer sidebar, FA6 icons, sticky on desktop) and wrap all nine exchange admin pages in it. Newsletter and promotions drop the ad-hoc containers they had grown; Site Admin links back to /admin and /admin/users. Verified: all nine routes SSR 200 with the shell markup on a local dev server; exchange suite 2,903 green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Restores the /admin/exchange admin section “shell” (container bounds + sidebar navigation) by introducing a shared wrapper component and applying it across all exchange admin pages, compensating for the fact that this repo does not mount Nuxt layouts.
Changes:
- Added
AdminExchangeShell(viaapp/components/admin/ExchangeShell.vue) to provide admin breadcrumb, bounded layout, and a sticky section side menu with moderation/message-queue badges. - Updated all nine
/admin/exchange/*pages to wrap their content in<AdminExchangeShell>. - Simplified newsletter/promotions pages by removing their ad-hoc container wrappers in favor of the shared shell.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| app/pages/admin/exchange/wanted.vue | Wraps page content with the shared admin exchange shell. |
| app/pages/admin/exchange/promotions.vue | Replaces local container with the shared shell for consistent bounds/nav. |
| app/pages/admin/exchange/newsletter.vue | Replaces local container with the shared shell for consistent bounds/nav. |
| app/pages/admin/exchange/moderation.vue | Wraps page content with the shared admin exchange shell. |
| app/pages/admin/exchange/messages.vue | Wraps page content with the shared admin exchange shell. |
| app/pages/admin/exchange/listings.vue | Wraps page content with the shared admin exchange shell. |
| app/pages/admin/exchange/index.vue | Wraps page content with the shared admin exchange shell. |
| app/pages/admin/exchange/finds.vue | Wraps page content with the shared admin exchange shell. |
| app/pages/admin/exchange/announcements.vue | Wraps page content with the shared admin exchange shell. |
| app/components/admin/ExchangeShell.vue | Introduces the reusable shell providing breadcrumb, sidebar navigation, and badge counts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the /admin/exchange regression Cole flagged: no side menu (sub-pages unreachable) and content not bounded like other admin pages.
Root cause: the TME admin pages were ported with
layout: 'admin', but this app'sapp.vuerenders<NuxtPage>without<NuxtLayout>— layouts never mount anywhere in this repo, so the declaration is inert and the pages rendered bare (they relied on TME's drawer layout for both the container and the sidebar).Fix: new
AdminExchangeShellcomponent (container + ADMIN breadcrumb + section side menu with moderation/message-queue badges, FA6 icons, daisyUI menu, sticky on desktop, Site Admin links back to /admin + /admin/users) and all nine/admin/exchangepages wrap themselves in it — matching how this repo's other admin pages self-contain their shell. Newsletter/promotions drop the ad-hoc containers they'd grown.Verified: nine routes SSR 200 with shell markup on a local dev server (auth gate then redirects, as designed); exchange suite 2,903 passing. Admin surfaces are intentionally English-only, so no i18n blocks.
🤖 Generated with Claude Code