Skip to content

Update status code and description for model runner failure case #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nitinbhojwani merged 2 commits into from
Dec 8, 2025
Merged

Update status code and description for model runner failure case #870

nitinbhojwani merged 2 commits into from
Dec 8, 2025
+2 −2

Conversation

@nitinbhojwani
Copy link
Contributor

@nitinbhojwani nitinbhojwani commented Dec 5, 2025

Why

  • status-code FAILURE is an incorrect status-code, when the runner item processing fails

How

  • Update status code to RUNNER_PROCESSING_FAILED for model runner failure case

Tests

  • Existing tests

@nitinbhojwani nitinbhojwani self-assigned this Dec 5, 2025
@github-actions
Copy link

github-actions bot commented Dec 8, 2025

Code Coverage

Package Line Rate Health
clarifai 45% ❌
clarifai.cli 58% ➖
clarifai.cli.templates 46% ❌
clarifai.client 67% ➖
clarifai.client.auth 67% ➖
clarifai.constants 100% ✔
clarifai.datasets 100% ✔
clarifai.datasets.export 80% ✔
clarifai.datasets.upload 75% ➖
clarifai.datasets.upload.loaders 37% ❌
clarifai.models 100% ✔
clarifai.modules 0% ❌
clarifai.rag 0% ❌
clarifai.runners 53% ➖
clarifai.runners.models 62% ➖
clarifai.runners.pipeline_steps 41% ❌
clarifai.runners.pipelines 77% ➖
clarifai.runners.utils 62% ➖
clarifai.runners.utils.data_types 72% ➖
clarifai.schema 100% ✔
clarifai.urls 60% ➖
clarifai.utils 60% ➖
clarifai.utils.evaluation 67% ➖
clarifai.workflows 95% ✔
Summary 62% (8704 / 13986) ➖

Minimum allowed line rate is 50%

@nitinbhojwani nitinbhojwani enabled auto-merge (squash) December 8, 2025 14:45
@nitinbhojwani nitinbhojwani merged commit abf68d5 into master Dec 8, 2025
11 of 17 checks passed
@nitinbhojwani nitinbhojwani deleted the nitin/TP-1943-correct-runner-failure-status-code branch December 8, 2025 16:42
Copilot AI added a commit that referenced this pull request Dec 23, 2025
@mogith-pn
Add all merged PRs to changelog since 11.12.1
40c1daf 
Added 10 PRs merged after 11.12.1 release (2025-12-03):
- Added: PRs #843, #856, #860, #875
- Changed: PR #870
- Fixed: PRs #858, #867, #868, #877, #879

All PRs include reference links per feedback.

Co-authored-by: mogith-pn <143642606+mogith-pn@users.noreply.github.com>
Copilot AI mentioned this pull request Dec 23, 2025
Merged
sainivedh pushed a commit that referenced this pull request Dec 23, 2025
@mogith-pn
Bump version to 11.12.2 and update changelog (#883)
a12ebb5 
* Initial plan

* Bump version to 11.12.2 and update changelog

Co-authored-by: mogith-pn <143642606+mogith-pn@users.noreply.github.com>

* Add all merged PRs to changelog since 11.12.1

Added 10 PRs merged after 11.12.1 release (2025-12-03):
- Added: PRs #843, #856, #860, #875
- Changed: PR #870
- Fixed: PRs #858, #867, #868, #877, #879

All PRs include reference links per feedback.

Co-authored-by: mogith-pn <143642606+mogith-pn@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: mogith-pn <143642606+mogith-pn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patricklundquist patricklundquist patricklundquist approved these changes

@wemoveon2 wemoveon2 Awaiting requested review from wemoveon2

@mimarcel mimarcel Awaiting requested review from mimarcel

Assignees

@nitinbhojwani nitinbhojwani

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nitinbhojwani @patricklundquist