Skip to content

Conversation

@wemoveon2
Copy link
Contributor

@wemoveon2 wemoveon2 commented Nov 6, 2025

Why

  • Want to start building two images for amd and arm but want to reuse checkpoint layer between the two to optimize storage

How

  • Separate checkpoint to architecture agnostic stage so downstream architecture specific stage can reuse instead of duplicating

Tests

  • Existing tests using dockerfile template to build images pass

Notes

@wemoveon2 wemoveon2 requested a review from Copilot November 6, 2025 20:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the Dockerfile template to use a multi-stage build pattern, separating model asset downloading from the final image creation to optimize build performance for multi-architecture builds.

  • Introduces a new "model-assets" stage that runs architecture-agnostic operations once on the build node
  • Moves checkpoint downloading and file copying to Stage 1 to avoid redundant work across target platforms
  • Updates the final stage to copy pre-built assets from Stage 1 instead of re-executing build steps

@wemoveon2 wemoveon2 requested a review from Copilot November 6, 2025 20:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

@wemoveon2 wemoveon2 requested a review from Copilot November 6, 2025 20:49
@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Code Coverage

Package Line Rate Health
clarifai 45%
clarifai.cli 44%
clarifai.cli.templates 33%
clarifai.client 67%
clarifai.client.auth 67%
clarifai.constants 100%
clarifai.datasets 100%
clarifai.datasets.export 80%
clarifai.datasets.upload 75%
clarifai.datasets.upload.loaders 37%
clarifai.models 100%
clarifai.modules 0%
clarifai.rag 72%
clarifai.runners 53%
clarifai.runners.models 59%
clarifai.runners.pipeline_steps 41%
clarifai.runners.pipelines 70%
clarifai.runners.utils 63%
clarifai.runners.utils.data_types 72%
clarifai.schema 100%
clarifai.urls 60%
clarifai.utils 60%
clarifai.utils.evaluation 67%
clarifai.workflows 95%
Summary 62% (8217 / 13338)

Minimum allowed line rate is 50%

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

@wemoveon2 wemoveon2 merged commit ae04a4f into master Nov 6, 2025
17 checks passed
@wemoveon2 wemoveon2 deleted the 6927 branch November 6, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants